[llvm] r308062 - [Dominators] Implement incremental deletions

[Tobias Grosser via llvm-commits]

On Thu, Jul 20, 2017, at 07:38 PM, Tobias Grosser via llvm-commits
wrote:
> Hi Jakub,
> 
> some small post-commit comments:
> 
> On Fri, Jul 14, 2017, at 11:58 PM, Jakub Kuderski via llvm-commits
> wrote:
> > Author: kuhar
> > Date: Fri Jul 14 14:58:53 2017
> > New Revision: 308062
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=308062&view=rev
> > Log:
> > [Dominators] Implement incremental deletions
> > +  /// tree is informed about makes some (domominator) subtree
> > unreachable -- in
> 
> dominator
> 
> > +  // Checks if a node has proper support, as defined on the page 3 and
> > later
> > +  // explained on the page 7 of the second paper.
> 
> Very nice that you cite some paper, but which exactly is the "second
> paper"? I could not find a reference in the code.

Sorry, it seems I did not pay enough attention. I now get it.

I would probably write "see paper [2] at the top of the file" and index
the papers accordingly. However, this is really now only a minor
difference.

Best,
Tobias