[llvm] r308493 - GlobalISel: select G_EXTRACT and G_INSERT instructions on AArch64.

[Diana Picus via llvm-commits]

No problem, glad you could sort it out!

On 21 July 2017 at 01:05, Tim Northover <tnorthover at apple.com> wrote:
> On 20 Jul 2017, at 09:11, Tim Northover via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>> I reverted this because it broke something in the test-suite:
>>> http://lab.llvm.org:8011/builders/clang-cmake-aarch64-global-isel/builds/185
>>
>> Oh dear, sorry about that. I'll look into it right away.
>
> Well that was fun! Turns out the Localizer was placing a G_FRAME_INDEX before the "this is where unwinding should jump to" EH_LABEL. Before, all that code was chucked out when the fallback was taken; with the G_INSERT/G_EXTRACT patch it was actually emitted.
>
> I've put a fix together which passes the test-suite, so I'll polish it up and commit. Sorry again that you had to revert.
>
> Tim.