[PATCH] D35706: [ELF] Remove processNonSectionCommands

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 16:30:25 PDT 2017


phosek created this revision.
phosek added a project: lld.
Herald added a subscriber: emaste.

This method is no longer being used anywhere.


Repository:
  rL LLVM

https://reviews.llvm.org/D35706

Files:
  ELF/LinkerScript.cpp
  ELF/LinkerScript.h


Index: ELF/LinkerScript.h
===================================================================
--- ELF/LinkerScript.h
+++ ELF/LinkerScript.h
@@ -288,7 +288,6 @@
 
   bool shouldKeep(InputSectionBase *S);
   void assignOffsets(OutputSectionCommand *Cmd);
-  void processNonSectionCommands();
   void assignAddresses();
   void allocateHeaders(std::vector<PhdrEntry> &Phdrs);
   void addSymbol(SymbolAssignment *Cmd);
Index: ELF/LinkerScript.cpp
===================================================================
--- ELF/LinkerScript.cpp
+++ ELF/LinkerScript.cpp
@@ -790,15 +790,6 @@
   removeEmptyCommands();
 }
 
-void LinkerScript::processNonSectionCommands() {
-  for (BaseCommand *Base : Opt.Commands) {
-    if (auto *Cmd = dyn_cast<SymbolAssignment>(Base))
-      assignSymbol(Cmd, false);
-    else if (auto *Cmd = dyn_cast<AssertCommand>(Base))
-      Cmd->Expression();
-  }
-}
-
 void LinkerScript::allocateHeaders(std::vector<PhdrEntry> &Phdrs) {
   uint64_t Min = std::numeric_limits<uint64_t>::max();
   for (OutputSectionCommand *Cmd : OutputSectionCommands) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35706.107604.patch
Type: text/x-patch
Size: 1074 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170720/731e1a6b/attachment.bin>


More information about the llvm-commits mailing list