[PATCH] D35651: [ELF] Align the value if needed when computing the expression

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 15:41:33 PDT 2017


phosek added a comment.

In https://reviews.llvm.org/D35651#816244, @ruiu wrote:

> The test you added doesn't seem to exercise the code you added. Don't you need something like `ALIGN(3, 8) + 10` to test that?


I have added few more test cases. This one is still useful because it checks that the relative case works with alignment (i.e. it'd break if we used `A.getValue() + B.getValue()` or `A.getValue() - B.getValue()`).


Repository:
  rL LLVM

https://reviews.llvm.org/D35651





More information about the llvm-commits mailing list