[PATCH] D35523: [AMDGPU] refactor WQM pass in preparation for WWM (NFCI)

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

One minor comment. Either way, LGTM.



================
Comment at: lib/Target/AMDGPU/SIWholeQuadMode.cpp:228-236
+  // Ignore if the flag is already encompassed by the existing needs.
+  if ((II.Needs & Flag) == Flag)
     return;
 
-  II.Needs = Flag;
+  // Remove any disabled states from the flag. The user that required it gets
+  // an undefined value in the helper lanes. For example, this can happen if
+  // the result of an atomic is used by instruction that requires WQM, where
----------------
I think you can mask out the Flag first.


https://reviews.llvm.org/D35523