[PATCH] D35643: [DWARF] Added check that verifies that no abbreviation declaration has more than one attribute with the same name.

[Spyridoula Gravani via Phabricator via llvm-commits]

sgravani added a comment.

In https://reviews.llvm.org/D35643#815593, @dblaikie wrote:

> In https://reviews.llvm.org/D35643#815498, @sgravani wrote:
>
> > In https://reviews.llvm.org/D35643#815473, @probinson wrote:
> >
> > > Wouldn't you also want to verify .debug_abbrev.dwo?
> >
> >
> > Ideally, yes (as well as other sections from the split dwarf5 proposal).
> >  So far I've focused on verifications for/related to the .debug_info section.
>
>
> I'll +1 Paul's comment - seems worthwhile generalizing things across .dwo/non-.dwo where it's convenient/easy - otherwise we'll end up with a weirdly inconsistent verification coverage.
>
> > Is it the case that we may need abbreviation declarations for .debug_info section from .debug_abbrev.dwo?
>
> No, .debug_abbrev.dwo would only apply to .debug_info.dwo - but pretty much any check you can do for .debug_info you should be able to do for .debug_info.dwo


I went ahead with the generalization. https://reviews.llvm.org/D35698

Thanks for the feedback!


Repository:
  rL LLVM

https://reviews.llvm.org/D35643