[llvm] r308319 - [TRE] Simplify canTRE() a bit using all_of(). NFCI.

Chris Lattner via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 12:07:04 PDT 2017


> On Jul 18, 2017, at 9:13 PM, Davide Italiano <davide at freebsd.org> wrote:
> 
>> Hi Davide,
>> 
>> What’s the specific question?
>> 
>> -Chris
> 
> Oh, I replied on the PR, but let me elaborate here (apologies if I
> wasn't clear).
> I assume you don't have anymore the C/C++ code that caused the poor
> codegen, and I wasn't able to trigger it from several programs I
> built. At this point, I'm not entirely sure whether it's still
> relevant special casing for dynamic allocas in TRE (although the
> codegen is not great). That said, I thought about this a little more
> and probably it's easier to keep the status quo as there's some risk
> of regressing.

Got it, I followed up in the PR with some advice on how to figure out if this is doing anything :-)

-Chris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170720/6fb8cb6c/attachment.html>


More information about the llvm-commits mailing list