[PATCH] D35553: Define OFF_T as 64-bit integer on NetBSD

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:135
-// like pread and mmap, as opposed to pread64 and mmap64.
-// FreeBSD, Mac and Linux/x86-64 are special.
-#if SANITIZER_FREEBSD || SANITIZER_MAC || \
----------------
krytarowski wrote:
> filcab wrote:
> > I don't think rewording the comment should be done in the same commit as adding NetBSD support.
> I can add a note that NetBSD is special too.  Is this fine?
Forgot to comment: Yes, it's fine. Feel free to reflow the comment if needed after your addition. If it's directly related to the patch, it makes sense to change the comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D35553