[PATCH] D34904: [CGP] use subtract of cmps for result of memcmp expansion

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 09:23:47 PDT 2017


nemanjai added a comment.

In https://reviews.llvm.org/D34904#815919, @RKSimon wrote:

> In https://reviews.llvm.org/D34904#807911, @RKSimon wrote:
>
> > This makes sense to me if the PowerPC guys are happy.
>
>
> @nemanjai @echristo @hfinkel Are you guys happy with this approach?


Seems perfectly fine to me. Let's wait and see if Eric or Hal have any further objections.


https://reviews.llvm.org/D34904





More information about the llvm-commits mailing list