[PATCH] D35554: Add NetBSD support in sanitizer_platform_limits_posix.*

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:296
+#define SHM_STAT -1
+  unsigned struct_shm_info_sz = -1;
+#endif
----------------
filcab wrote:
> Setting these to `-1` looks weird. Can you at least add a small comment? I'm assuming these simply don't exist on NetBSD.
These interfaces are absent on NetBSD.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.h:124
 #if SANITIZER_LINUX || SANITIZER_FREEBSD
-
 #if defined(__powerpc64__) || defined(__s390__)
----------------
filcab wrote:
> Stray change.
I will fix it.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.h:182
+    u32 aio_buf;
+    u32 aio_nbytes;
+    u32 aio_fildes;
----------------
filcab wrote:
> Maybe use `uptr` (Or `char*`) for `aio_buf` and `long` for `aio_nbytes` and others below?
> It seems you can merge these two platforms.
I will go for it.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.h:191
+#else
+#error port this to your platform
+#endif
----------------
filcab wrote:
> There's more than one of these. Right now you're just dealing with x86 and x86_64, so why not just have one `#error` at the start of the file if you need to, and then not have these cases?
It will be gone with the above change.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.h:982
+  };
+#define SANITIZER_HAS_STRUCT_FILE 0  // not ported
 #else
----------------
filcab wrote:
> If this is set to 0, can't you just use the `#else` case, which defined `__sanitizer_FILE` to `void`?
I don't recall right now if I needed to have __sanitizer_FILE != void to make it buildable/functional... but for now I will go for it now.

It will be ported in future.


Repository:
  rL LLVM

https://reviews.llvm.org/D35554