[PATCH] D35553: Define OFF_T as 64-bit integer on NetBSD

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 06:36:11 PDT 2017


krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:135
-// like pread and mmap, as opposed to pread64 and mmap64.
-// FreeBSD, Mac and Linux/x86-64 are special.
-#if SANITIZER_FREEBSD || SANITIZER_MAC || \
----------------
filcab wrote:
> I don't think rewording the comment should be done in the same commit as adding NetBSD support.
I can add a note that NetBSD is special too.  Is this fine?


Repository:
  rL LLVM

https://reviews.llvm.org/D35553





More information about the llvm-commits mailing list