[PATCH] D34781: Introduce a MCReloc class

Gerolf Hoflehner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 17:03:35 PDT 2017


Gerolf added a comment.

It is not clear to me if and how the original questions have been answered by this patch yet. Could you elaborate and add comments, please? Much appreciate!

What relocation should we map FK_Data_1 to? What if IsPCRel was set to true?
What is the addend? FixedValue or Target.getConstant()?
What is the meaning of "foo - bar at got"?
There is *a lot* of duplicated code is the various obj writers.

>> Specifically it doesn't look like the code size changed much.


https://reviews.llvm.org/D34781





More information about the llvm-commits mailing list