[PATCH] D35418: Handle clang-tools-extra project in docker scripts.
Ilya Biryukov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 20 01:08:35 PDT 2017
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
================
Comment at: utils/docker/scripts/build_install_llvm.sh:71
+ fi
+ CMAKE_LLVM_ENABLE_PROJECTS="$CMAKE_LLVM_ENABLED_PROJECTS$PROJ"
+}
----------------
mehdi_amini wrote:
> Why don't you just do everything in the if in one assignment?
Totally agree, it's more readable.
Changed the code accordingly.
https://reviews.llvm.org/D35418
More information about the llvm-commits
mailing list