[PATCH] D35334: ThinLTO Minimized Bitcode File Size Reduction
Haojie Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 19 19:29:05 PDT 2017
haojiewang marked 5 inline comments as done.
haojiewang added inline comments.
================
Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:4120
+
+ // Write per-module global value summary.
+ writePerModuleGlobalValueSummary();
----------------
pcc wrote:
> This comment isn't very useful, it just says the same thing as the code. I'd remove it.
>
> I think the other comments in this function are self evident from the code as well, but up to you if you want to keep them.
I just keep the module hash comment, since I inline that function.
https://reviews.llvm.org/D35334
More information about the llvm-commits
mailing list