[PATCH] D35643: [DWARF] Added check that verifies that no abbreviation declaration has more than one attribute with the same name.

[Frederic Riss via Phabricator via llvm-commits]

friss accepted this revision.
friss added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/tools/llvm-dwarfdump/X86/verify_debug_info.s:84
 	.byte	1                       ## DW_FORM_addr
-	.byte	18                      ## DW_AT_high_pc
+	.byte	17                      ## DW_AT_high_pc -- Error: Die at offset 0x0000002b contains multiple DW_AT_low_pc attributes.
 	.byte	6                       ## DW_FORM_data4
----------------
sgravani wrote:
> friss wrote:
> > By adding this just to the abrrev table, I think you completely break the DIE tree decoding. Wouldn't it be better to add it to the debug_info section as well? 
> I'm not sure what you mean.. Can you explain?
Sorry, I thought this was an insertion, but now I see that you replaced an attribute with one with a equivalent form. This LGTM, thanks!


https://reviews.llvm.org/D35643