[llvm] r308069 - [libFuzzer] Allow non-fuzzer args after -ignore_remaining_args=1

[Kostya Serebryany via llvm-commits]

On Wed, Jul 19, 2017 at 4:30 PM, Reid Kleckner <rnk at google.com> wrote:

> I fixed things the existing way in r308548.
>
> I would like it if we could avoid problems like this in the future when
> people add tests that use the optional hooks. As it stands now, they are
> unlikely to discover that every optional hook added to a test needs to be
> written down in CMakeLists.txt. We're currently doing things this way to
> make the source code of the tests clean and to avoid dependencies on
> FuzzerInterface.h. The question is, what do we want to compromise on:
> 1. Make tests ugly, but cross-platform, and representative of what users
> must do to be cross-platform
> 2. Maintain status quo, tests break every so often, but now maybe we'll
> remember why next time
>

I'd really love to keep (most of) the tests independent of libFuzzer and
FuzzerInterface.h so that other engines could use them.
(same applies to real-life fuzz targets).
And I would also prefer to avoid ugly ifdefs.
So, let's "Maintain status quo" for now and once the burden on Windows
becomes intolerable invent some 4-th way.

Thanks for the fix!


> 3. Require users to include FuzzerInterface.h, introducing more
> dependencies, but it will allow us to magically abstract Windows
> portability issues
>
> On Mon, Jul 17, 2017 at 5:58 PM, Kostya Serebryany <kcc at google.com> wrote:
>
>> Let me add
>> UNSUPPORTED: windows
>>
>> On Mon, Jul 17, 2017 at 5:50 PM, Reid Kleckner <rnk at google.com> wrote:
>>
>>> I didn't have time to get to this today. I can look at it tomorrow. In
>>> the meantime, can somebody XFAIL this?
>>>
>>> On Mon, Jul 17, 2017 at 5:34 PM, Kostya Serebryany <kcc at google.com>
>>> wrote:
>>>
>>>> +rnk
>>>>
>>>> On Mon, Jul 17, 2017 at 12:25 PM, Justin Bogner <mail at justinbogner.com>
>>>> wrote:
>>>>
>>>>> The output on the bot isn't terribly informative and I don't have a
>>>>> windows machine. Could somebody run the failing command for me and
>>>>> paste
>>>>> the output? It's as follows:
>>>>>
>>>>>   "LLVMFuzzer-FlagsTest" "--foo-bar" "-runs=10"
>>>>> "-ignore_remaining_args=1" "--baz" "-help=1" "test"
>>>>>
>>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170719/a35a7ebb/attachment-0001.html>