[llvm] r308548 - Fix fuzzer-flags.test on Windows

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 16:22:06 PDT 2017


Author: rnk
Date: Wed Jul 19 16:22:06 2017
New Revision: 308548

URL: http://llvm.org/viewvc/llvm-project?rev=308548&view=rev
Log:
Fix fuzzer-flags.test on Windows

The optional external function callbacks have to be exported in order
for them to be called. The test was failing because libFuzzer wasn't
calling LLVMFuzzerInitialize.

We can reconsider if this is the best way to mark these optional
callbacks exported later.

Modified:
    llvm/trunk/lib/Fuzzer/test/CMakeLists.txt
    llvm/trunk/lib/Fuzzer/test/fuzzer-flags.test

Modified: llvm/trunk/lib/Fuzzer/test/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/test/CMakeLists.txt?rev=308548&r1=308547&r2=308548&view=diff
==============================================================================
--- llvm/trunk/lib/Fuzzer/test/CMakeLists.txt (original)
+++ llvm/trunk/lib/Fuzzer/test/CMakeLists.txt Wed Jul 19 16:22:06 2017
@@ -158,6 +158,7 @@ function(test_export_symbol target symbo
   endif()
 endfunction()
 
+test_export_symbol(FlagsTest "LLVMFuzzerInitialize")
 test_export_symbol(InitializeTest "LLVMFuzzerInitialize")
 test_export_symbol(BogusInitializeTest "LLVMFuzzerInitialize")
 test_export_symbol(CustomCrossOverTest "LLVMFuzzerCustomCrossOver")

Modified: llvm/trunk/lib/Fuzzer/test/fuzzer-flags.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/test/fuzzer-flags.test?rev=308548&r1=308547&r2=308548&view=diff
==============================================================================
--- llvm/trunk/lib/Fuzzer/test/fuzzer-flags.test (original)
+++ llvm/trunk/lib/Fuzzer/test/fuzzer-flags.test Wed Jul 19 16:22:06 2017
@@ -1,6 +1,3 @@
-# Does not work on windows for unknown reason.
-UNSUPPORTED: windows
-
 RUN: LLVMFuzzer-FlagsTest -foo_bar=1 2>&1 | FileCheck %s --check-prefix=FOO_BAR
 FOO_BAR: WARNING: unrecognized flag '-foo_bar=1'; use -help=1 to list all flags
 FOO_BAR: BINGO




More information about the llvm-commits mailing list