[PATCH] D35649: AMDGPU: Correct encoding for global instructions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 16:01:39 PDT 2017


arsenm created this revision.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng.

The soffset field needs to be be set to 0x7f to disable it,
not 0. 0 is interpreted as an SGPR offset.

This should be enough to get basic usage of the global instructions
working. Technically it is possible to use an SGPR_32 offset,
but I'm not sure if it's correct with 64-bit pointers, but
that is not handled now. This should also be cleaned up
to be more similar to how different MUBUF modes are handled,
and to have InstrMappings between the different types.


https://reviews.llvm.org/D35649

Files:
  lib/Target/AMDGPU/FLATInstructions.td
  test/MC/AMDGPU/flat-gfx9.s
  test/MC/AMDGPU/flat-global.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35649.107403.patch
Type: text/x-patch
Size: 20153 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170719/8fb35443/attachment.bin>


More information about the llvm-commits mailing list