[PATCH] D35638: A fix for bug33826

[David Kreitzer via Phabricator via llvm-commits]

DavidKreitzer added inline comments.


================
Comment at: lib/Target/X86/X86InterleavedAccess.cpp:106
+  if (isa<LoadInst>(Inst)) {
+    if (DL.getTypeSizeInBits(ShuffleVecTy) != 256)
+      return false;
----------------
You could make the ShuffleVecTy check more generic by testing this, which is similar to what you had before adding interleaved store support:

```
if (WideInstSize != DL.getTypeSizeInBits(ShuffleVecType) * Factor)
  return false;
```

I get your point about the profitability. I think your comment in the test adequately captures that.


https://reviews.llvm.org/D35638