[PATCH] D35640: [lld] [COFF] Align import address chunks to the pointer size

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 14:40:23 PDT 2017


mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: COFF/Chunks.cpp:189-190
+    fatal("misaligned ldr/str offset");
   Imm >>= Size;
   applyArm64Imm(Off, Imm);
 }
----------------
ruiu wrote:
> It is probably better to write this as `applyArm64Imm(Off, Imm >> Size)`
Addressing this in https://reviews.llvm.org/D35646 as well.


https://reviews.llvm.org/D35640





More information about the llvm-commits mailing list