[PATCH] D35373: Use delegation instead of inheritance

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFObj.h:24
+// result is not used.
+class DWARFObj {
+  DWARFSection Dummy;
----------------
I'd wonder about the name - DWARFObject? DWARFObjectSections?


================
Comment at: unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp:2186
+  std::unique_ptr<DWARFContext> Ctx2 =
+      DWARFContext::create(*Obj.get(), nullptr, [&](Error E) {
+        ++Errors;
----------------
"*Obj.get()" can probably be "*Obj"? (similarly above)


https://reviews.llvm.org/D35373