[PATCH] D35640: [lld] [COFF] Align import address chunks to the pointer size

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Chunks.cpp:186
 static void applyArm64Ldr(uint8_t *Off, uint64_t Imm) {
   int Size = read32le(Off) >> 30;
+  if ((Imm & ((1 << Size) - 1)) != 0)
----------------
It is better to use uint32_t so that you don't need to think about sign-extended shift.


================
Comment at: COFF/Chunks.cpp:187
   int Size = read32le(Off) >> 30;
+  if ((Imm & ((1 << Size) - 1)) != 0)
+    fatal("Misaligned ldr/str offset");
----------------
Use llvm::isPowerOf2_32.


================
Comment at: COFF/Chunks.cpp:188
+  if ((Imm & ((1 << Size) - 1)) != 0)
+    fatal("Misaligned ldr/str offset");
   Imm >>= Size;
----------------
Error messages should start with lowercase letter.


https://reviews.llvm.org/D35640