[PATCH] D35425: Implement parsing and writing of a single xml manifest file.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/lib/Support/WindowsManifestMerger.cpp:43
+#ifdef LLVM_LIBXML2_ENABLED
+  std::unique_ptr<MemoryBuffer> OutputBuffer;
+  unsigned char *XmlBuff;
----------------
This is dead now.


================
Comment at: llvm/tools/llvm-mt/llvm-mt.cpp:146
+  if (!OutputBuffer) {
+    outs() << "llvm-mt: empty manifest not written\n";
+  } else {
----------------
ruiu wrote:
> Isn't this an error? Looks like this program exits with 0 in this case.
How about this?


https://reviews.llvm.org/D35425