[PATCH] D35569: [ARM] Remove FeatureNoARM implies ModeThumb.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In https://reviews.llvm.org/D35569#814990, @efriedma wrote:

> We want to make sure "-mcpu=cortex-m0" implies -mthumb in clang... but yes, we probably don't want to mess with the target features in the backend.


I agree that this would be ideal from the user's perspective. I am not sure what the best way to implement that would be though. The information which CPUs support which modes is available in the backend, but I am not sure how we would make use of that information in Clang. And duplicating the information in Clang does not seem ideal. Any suggestions how we could tackle that?

> In terms of cleaning this up, we should probably have "FeatureARM", for CPUs which support ARM-mode execution, rather than "FeatureNoARM"; negative features are confusing.

That sounds like a  good idea. I'll update this patch tomorrow, unless there are any objections.


https://reviews.llvm.org/D35569