[PATCH] D35192: [ARM] Use ADDCARRY / SUBCARRY
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 19 11:09:18 PDT 2017
efriedma added inline comments.
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:7478
+ Carry);
+ }
+
----------------
Maybe you could refactor this to share a little more code for ADDCARRY/SUBCARRY?
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:9996
+ }
+ }
+
----------------
Do we still need the code for SUBC here?
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:12828
+ return;
+ }
+ }
----------------
Do we still need the code for SUBC here?
https://reviews.llvm.org/D35192
More information about the llvm-commits
mailing list