[PATCH] D35609: [LICM] Make sinkRegion and hoistRegion non-recursive

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 10:41:59 PDT 2017


davide added a comment.

If I understand the patch correctly, aren't we just iterating children->parent, therefore the order of siblings should be irrelevant in this case ?
(i.e. the worklist is sorted according to the dominance relation and shouldn't really matter if we process two siblings in the dominator in different order?)
I think Sanjoy's suggestion works if my reasoning is correct, although I'm also fine with the current version of the patch (I don't have a strong preference for one or the other).


https://reviews.llvm.org/D35609





More information about the llvm-commits mailing list