[polly] r308152 - ScopInfo: Remove not-in-DomainMap statements in separate function

[Michael Kruse via llvm-commits]

2017-07-19 18:42 GMT+02:00 Tobias Grosser <tobias at grosser.es>:
>> 2017-07-17 1:55 GMT+02:00 Tobias Grosser via llvm-commits
>> <llvm-commits at lists.llvm.org>:
>> > Author: grosser
>> > Date: Sun Jul 16 16:55:38 2017
>> > New Revision: 308152
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=308152&view=rev
>> > Log:
>> > ScopInfo: Remove not-in-DomainMap statements in separate function
>> >
>> > This separates ScopBuilder internal and ScopBuilder external functionality.
>>
>> I don't quite understand the motivation. The refactoring of
>> removeStmts to be usable in more contexts makes sense (although I
>> think just providing a `removeStmt()` method that could be called
>> individually would have been a simpler solution than a callback)
>
> The motivation of this change was to make it easier to limit the scope
> of DomainMap to the ScopBuilder by removing the use of DomainMap from
> simplifySCoP, which is also used in Simplify, e.g.
>
>> If the purpose was to separate removeStmtNotInDomainMap() which is
>> only used by ScopBuilder, why is it still a method of ScopInfo instead
>> one of ScopBuilder?
>
> Because the DomainMap is still part of Scop. I was hoping that Nandini
> can move this function to ScopBuilder when she makes the DomainMap
> local.

OK. Thank you for the context and explanation.

Michael