[PATCH] D35608: Migrate SimplifyLibCalls to new OptimizationRemarkEmitter

[Sam Elliott via Phabricator via llvm-commits]

lenary added a comment.

In https://reviews.llvm.org/D35608#814564, @davide wrote:

> Please add a test exercising this codepath (you can take inspiration from the ones in GVN or LV)


Working on it



================
Comment at: lib/Transforms/InstCombine/InstCombineInternal.h:22
 #include "llvm/Analysis/LoopInfo.h"
+#include "llvm/Analysis/OptimizationDiagnosticInfo.h"
 #include "llvm/Analysis/TargetFolder.h"
----------------
fhahn wrote:
> Is this required? It looks like your are only using references to OptimizationRemarkEmitter in the header file, so the forward declaration at line 46 should be enough.
Ah, it's probably not, but without it i'll need one in `InstructionCombining.cpp` which I missed.


https://reviews.llvm.org/D35608