[PATCH] D35608: Migrate SimplifyLibCalls to new OptimizationRemarkEmitter

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

LGTM with one comment, but I think it would be good for @anemet to have a look too.



================
Comment at: lib/Transforms/InstCombine/InstCombineInternal.h:22
 #include "llvm/Analysis/LoopInfo.h"
+#include "llvm/Analysis/OptimizationDiagnosticInfo.h"
 #include "llvm/Analysis/TargetFolder.h"
----------------
Is this required? It looks like your are only using references to OptimizationRemarkEmitter in the header file, so the forward declaration at line 46 should be enough.


https://reviews.llvm.org/D35608