[PATCH] D35544: [AArch64] Force relocations for all ADRP instructions

[Tim Northover via Phabricator via llvm-commits]

t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.

Looks fine to me other than a nit about the MachO test. Unless the fix to that gets weird and you want to confirm it's right you can commit without uploading another revision.



================
Comment at: test/MC/AArch64/macho-adrp-missing-reloc.s:3
+
+; XFAIL: *
+; ADR/ADRP relocations must be GOT relative
----------------
This isn't really a failure. The usual way to check error messages is something like:

    ; RUN: not llvm-mc < %s -triple arm64-apple-darwin 2>&1 | FileCheck %s
    ; CHECK: error: ADR/ADRP relocations must be GOT relative

The "not" means it's acceptable for llvm-mc to "fail", and the FileCheck makes sure we get a vaguely sensible error message rather than a crash or some other nonsense.


https://reviews.llvm.org/D35544