[PATCH] D35471: [Polly] [RFC] Calculate AST expression type

[Tobias Grosser via Phabricator via llvm-commits]

grosser added a comment.

Hi Maximilian,

here another round of reviews:

It seems we loose some "braces":

  /home/grosser/Projects/polly/git/tools/polly/test/ScheduleOptimizer/pattern-matching-based-opts_5.ll:100:15: error: expected string not found in input
  ; CHECK-NEXT: Stmt_for_body6(-((ni + 4) % 4) + ni + c6, 2048 * c0 + 8 * c3 + c7, 256 * c1 + c5);
                ^
  <stdin>:80:2: note: scanning from here
   Stmt_for_body6(-ni + 4 % 4 + ni + c6, 2048 * c0 + 8 * c3 + c7, 256 * c1 + c5);



================
Comment at: lib/CodeGen/IslAst.cpp:542
+      Cond = isl_ast_expr_and(
+          Cond, isl_ast_build_expr_from_set(Build, OtherCondition));
+    }
----------------
You are syntactically connecting preconditions with a "&&". This does not allow for any simplifications. Instead, I suggest to intersect Cond, and only at the very end to build preconditions.




================
Comment at: lib/CodeGen/IslExprBuilder.cpp:794
+
+  auto OldBound = CurrentBound;
+  CurrentBound = Expr;
----------------
Please use full types, rather than 'auto'. (except for iterators or where the type is obvious)


================
Comment at: lib/External/isl/isl_ast_codegen.c:1656
+
 		isl_ast_build_free(for_build);
 	}
----------------
Unrelated change.


https://reviews.llvm.org/D35471