[PATCH] D35498: [LoopVectorizer] Use two step casting for float to pointer type.

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: test/Transforms/LoopVectorize/pr33804.ll:10
+target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
+target triple = "armv7-cros-linux-gnueabihf"
+
----------------
The ARM backend is not always compiled in all bots, this will break them. Please remove the triple.

Keeping the datalayout may be enough, if not, move them to target-specific directories and make sure you have at least on two very different targets (like ARM32 and x86_64).


================
Comment at: test/Transforms/LoopVectorize/pr33804.ll:86
+
+attributes #0 = { "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+dsp,+neon,+vfp3,-thumb-mode" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+dsp,+neon,+vfp3,-thumb-mode" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
do you really need all those attributes? Try to remove them and see if they change the results. If not, just clean them up.


================
Comment at: test/Transforms/LoopVectorize/pr33804.ll:96
+!2 = !{!"_ZTS8CvNode1D", !3, i64 0, !6, i64 4}
+!3 = !{!"float", !4, i64 0}
+!4 = !{!"omnipotent char", !5, i64 0}
----------------
You probably don't need any of those either.


https://reviews.llvm.org/D35498