[llvm] r308434 - Revert r274270, "[CMake] Module builds depend on target intrinsics_gen to be built first."

NAKAMURA Takumi via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 19 03:47:38 PDT 2017


Author: chapuni
Date: Wed Jul 19 03:47:38 2017
New Revision: 308434

URL: http://llvm.org/viewvc/llvm-project?rev=308434&view=rev
Log:
Revert r274270, "[CMake] Module builds depend on target intrinsics_gen to be built first."

I think modulemap is sufficient for intrinsics_gen in trunk. I won't find any issues around that.

Modified:
    llvm/trunk/CMakeLists.txt

Modified: llvm/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=308434&r1=308433&r2=308434&view=diff
==============================================================================
--- llvm/trunk/CMakeLists.txt (original)
+++ llvm/trunk/CMakeLists.txt Wed Jul 19 03:47:38 2017
@@ -843,15 +843,6 @@ add_subdirectory(lib/TableGen)
 
 add_subdirectory(utils/TableGen)
 
-# Force target to be built as soon as possible. Clang modules builds depend
-# header-wise on it as they ship all headers from the umbrella folders. Building
-# an entire module might include header, which depends on intrinsics_gen. This
-# should be right after LLVMSupport and LLVMTableGen otherwise we introduce a
-# circular dependence.
-if (LLVM_ENABLE_MODULES)
-  list(APPEND LLVM_COMMON_DEPENDS intrinsics_gen)
-endif(LLVM_ENABLE_MODULES)
-
 add_subdirectory(include/llvm)
 
 add_subdirectory(lib)




More information about the llvm-commits mailing list