[PATCH] D35117: [globalisel][tablegen] Add control-flow to the MatchTable.

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked 6 inline comments as done.
dsanders added a comment.

Thanks. I'll fix these for the commit.



================
Comment at: include/llvm/CodeGen/GlobalISel/InstructionSelector.h:118
+  /// Check the operand is a specific literal integer (i.e. MO.isImm() or
+  /// MO.isCImm() is true).
   /// - InsnID - Instruction ID
----------------
rovka wrote:
> rovka wrote:
> > Unrelated change, please commit separately.
> This is marked as done, but the change is still in the patch...
I marked it done because I'd pulled it out into my svn working copy ready to commit this morning (r308424). It will drop out after another rebase


================
Comment at: test/TableGen/GlobalISelEmitter.td:213
 // CHECK-NEXT:    // (add:i32 GPR32:i32:$src1, GPR32:i32:$src2) => (ADD:i32 GPR32:i32:$src1, GPR32:i32:$src2)
-// CHECK-NEXT:    GIR_MutateOpcode, /*InsnID*/0, /*RecycleInsnID*/ 0, /*Opcode*/MyTarget::ADD,
+// CHECK-NEXT:    GIR_MutateOpcode, /*InsnID*/0, /*RecycleInsnID*/0, /*Opcode*/MyTarget::ADD,
 // CHECK-NEXT:    GIR_ConstrainSelectedInstOperands, /*InsnID*/0,
----------------
rovka wrote:
> This is also an unrelated whitespace change (I guess it's not as bad as the previous one though, since it only shows up in a couple of places).
This one is a consequence of standardizing it in the handling of MatchTable::Comment()


https://reviews.llvm.org/D35117