[PATCH] D35598: Rework machine creation strategy

[Matthias Braun via Phabricator via llvm-commits]

MatzeB created this revision.
Herald added a subscriber: mcrosier.

Currently when submitting a run and the machine data does not match the
previous data, LNT creates a new machine with the same name (but
different id). This was often very confusing to users.

This changes the strategy to reject the submission if the data does not
match the previous data unless the `--update-machine` flag (or the
update_machine post parameters, etc.) is set in which case the new data
overrides the previous machine data.

Adding previously unset keys to the machine will not lead to a rejection
either way. Leaving out previously set keys is fine (but will not remove
the keys).

This new strategy will result in machine names being unique (except for
the case of older entries in the database before this change).


Repository:
  rL LLVM

https://reviews.llvm.org/D35598

Files:
  lnt/lnttool/import_data.py
  lnt/lnttool/main.py
  lnt/lnttool/viewcomparison.py
  lnt/server/db/testsuitedb.py
  lnt/server/ui/api.py
  lnt/server/ui/templates/submit_run.html
  lnt/server/ui/views.py
  lnt/util/ImportData.py
  lnt/util/ServerUtil.py
  tests/lnttool/Inputs/compile_submission_machine_diff_fine.json
  tests/lnttool/Inputs/compile_submission_machine_diff_reject.json
  tests/lnttool/submit.shtest

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35598.107223.patch
Type: text/x-patch
Size: 18530 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170719/b0f25646/attachment.bin>