[PATCH] D24623: AMDGPU: Implement memory model
Tony Tye via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 18 17:10:49 PDT 2017
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
One question, otherwise LGTM.
================
Comment at: lib/Target/AMDGPU/SIInstructions.td:102
let hasSideEffects = 1;
+ let maybeAtomic = 1;
}
----------------
Since a fence itself does not modify memory, and has no memory address operand, should it be marked `maybeatomic`?
https://reviews.llvm.org/D24623
More information about the llvm-commits
mailing list