[PATCH] D35498: [LoopVectorizer] Use two step casting for float to pointer type.

Manoj Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 15:51:24 PDT 2017


manojgupta marked 3 inline comments as done.
manojgupta added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:2967
+            // Casting is not possible.
+            return;
+          }
----------------
Ayal wrote:
> At this stage assert that this 'else' is not reached, rather than return silently w/o generating the final wide store.
> 
> Suggest to add a condition to Legal checking that types are compatible when forming interleave-groups.
Added assert in the createBitCast function.


https://reviews.llvm.org/D35498





More information about the llvm-commits mailing list