[PATCH] D35583: Debug Info: Add a file: field to DIImportedEntity

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 15:42:07 PDT 2017


probinson added a comment.

Sweet.  I don't have the chops to understand the Objective-C test but otherwise LGTM.



================
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1684
+                         HasFile ? getMDOrNull(Record[6]) : nullptr,
+                         HasFile ? Record[4] : 0, getMDString(Record[5]))),
         NextMetadataNo);
----------------
That's a nice touch.


https://reviews.llvm.org/D35583





More information about the llvm-commits mailing list