[PATCH] D35075: [AArch64] Redundant copy elimination - remove more zero copies.

[Geoff Berry via Phabricator via llvm-commits]

gberry added a comment.

Final comments below:



================
Comment at: lib/Target/AArch64/AArch64RedundantCopyElimination.cpp:155
-    // Track clobbered registers.
-    trackRegDefs(PredI, ClobberedRegs, TRI);
-
----------------
I find reviewing this part of the change a bit confusing since we're using ClobberedRegs in both knownRegValInBlock() and optimizeCopy(), but the uses are distinct as far as I can tell.  I wouldn't object to a refactoring change that split these uses into two variables.


https://reviews.llvm.org/D35075