[PATCH] D29892: ar: add llvm-dlltool support

Tue Jul 18 14:09:36 PDT 2017

Never mind, it's already been reverted. Keep that in mind for when it's reapplied though.

From: Shoaib Meenai <smeenai at fb.com>
Date: Tuesday, July 18, 2017 at 2:06 PM
To: Aleksey Shlyapnikov <alekseys at google.com>, Martell Malone <martellmalone at gmail.com>
Cc: Rui Ueyama <ruiu at google.com>, Peter Collingbourne <peter at pcc.me.uk>, "reviews+d29892+public+2a8588b74c42dd09 at reviews.llvm.org" <reviews+d29892+public+2a8588b74c42dd09 at reviews.llvm.org>, Michael Spencer <bigcheesegs at gmail.com>, Saleem Abdulrasool <compnerd at compnerd.org>, Ed Maste <emaste at freebsd.org>, Mehdi AMINI <joker.eph at gmail.com>, Bob Haarman <llvm at inglorion.net>, llvm-commits <llvm-commits at lists.llvm.org>, Martin Storsjö <martin at martin.st>, Mateusz Mikuła <mati865 at gmail.com>, Michał Górny <mgorny at gentoo.org>, Rafael Espíndola <rafael.espindola at gmail.com>
Subject: Re: [PATCH] D29892: ar: add llvm-dlltool support

That one sounds like a dependency issue. LLVM_TEST_TARGETS didn't include llvm-dlltool. Saleem is committing a fix.

Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Aleksey Shlyapnikov <alekseys at google.com>
Sent: Tuesday, July 18, 2017 2:02:18 PM
To: Martell Malone
Cc: Rui Ueyama; Peter Collingbourne; reviews+D29892+public+2a8588b74c42dd09 at reviews.llvm.org; Michael Spencer; Saleem Abdulrasool; Ed Maste; Mehdi AMINI; Bob Haarman; llvm-commits; Martin Storsjö; Mateusz Mikuła; Michał Górny; Rafael Espíndola; Shoaib Meenai
Subject: Re: [PATCH] D29892: ar: add llvm-dlltool support

That bot fails with

/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm_build_asan/test/DllTool/Output/coff-exports.def.script: line 1: llvm-dlltool: command not found

On Tue, Jul 18, 2017 at 2:00 PM, Martell Malone <martellmalone at gmail.com<mailto:martellmalone at gmail.com>> wrote:
We ran into this before with the casts.
It was previously a warning but someone made that warning an error on the build bots.
Fixed in rL308360

On Tue, Jul 18, 2017 at 9:51 PM, Rui Ueyama <ruiu at google.com<mailto:ruiu at google.com>> wrote:
Which error are you talking about? It doesn't seem like a gcc warning.

E.g. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6544/steps/check-llvm%20asan/logs/stdio<https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_sanitizer-2Dx86-5F64-2Dlinux-2Dfast_builds_6544_steps_check-2Dllvm-2520asan_logs_stdio&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=0y5rCE7DHDtJsAvWx8zx2WKMNybFDNoeS1JkDrdhjRQ&s=NGjqRZfFnGHhitPAAInehRIIDSuEV9ReGnSn-KxKtG4&e=>

On Tue, Jul 18, 2017 at 1:36 PM, Martell Malone <martellmalone at gmail.com<mailto:martellmalone at gmail.com>> wrote:
Thanks
I already replied to the thread from the build bot.
We have seen a similar cast gcc warning error before.
Easy fix in a follow up shortly.

On Tue 18 Jul 2017 at 20:31, Aleksey Shlyapnikov via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
alekseyshl added a comment.

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6544<https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_sanitizer-2Dx86-5F64-2Dlinux-2Dfast_builds_6544&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=0y5rCE7DHDtJsAvWx8zx2WKMNybFDNoeS1JkDrdhjRQ&s=4nrKF6yz4qNp5hGTSnf7XoptRCd2baMDQChcqRhhMnc&e=> is not happy about this patch.

Repository:
  rL LLVM

https://reviews.llvm.org/D29892<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D29892&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=0y5rCE7DHDtJsAvWx8zx2WKMNybFDNoeS1JkDrdhjRQ&s=TXjerh85FUsBVRf-81mjdX_4sH1j0FW6YeG53BoBifw&e=>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170718/330be4c7/attachment.html>