[PATCH] D35411: [SimplifyCFG] Defer folding unconditional branches to LateSimplifyCFG if it can destroy canonical loop structure.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Oh, LSR is generating the extra block?  That makes sense... but it seems mostly unrelated to the rest of this patch.  Does it have any impact on its own?



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:671
+    if (Preheaders.count(BB))
+      Preheaders.erase(BB);
     eliminateMostlyEmptyBlock(BB);
----------------
The "if" is redundant; erase() does nothing if the set doesn't contain BB.


https://reviews.llvm.org/D35411