[PATCH] D33048: [CMake] runtimes test targets need to depend on LLVM tools
Chris Bieneman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 18 13:44:22 PDT 2017
beanz added inline comments.
================
Comment at: llvm/trunk/runtimes/CMakeLists.txt:256
+ if(LLVM_INCLUDE_TESTS)
+ list(APPEND test_targets check-${runtime_name})
+ endif()
----------------
This blob here actually ends up duplicating the targets. During configuration of the runtime targets we generate a file "Components.cmake" that lists the build and check targets for each runtime library, and that gets imported back into the top-level build via the `SUB_COMPONENT_CHECK_TARGETS` variable.
This is what causes the CMake configuration errors on builds, and we need to remove this.
Repository:
rL LLVM
https://reviews.llvm.org/D33048
More information about the llvm-commits
mailing list