[PATCH] D35075: [AArch64] Redundant copy elimination - remove more zero copies.
Geoff Berry via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 18 13:13:23 PDT 2017
gberry added a comment.
First pass comments below:
================
Comment at: lib/Target/AArch64/AArch64RedundantCopyElimination.cpp:116
/// It's possible to determine the value of a register based on a dominating
/// condition. To do so, this function checks to see if the basic block \p MBB
/// is the target to which a conditional branch \p CondBr jumps and whose
----------------
This comment needs updating.
================
Comment at: lib/Target/AArch64/AArch64RedundantCopyElimination.cpp:229
+ case AArch64::SUBSWrs:
+ case AArch64::SUBSXrs: {
+ MCPhysReg DstReg = PredI.getOperand(0).getReg();
----------------
I think a few opcodes are missing here (it also might be a good idea to sort these so you can visually search through them more easily):
ADCSWr
ADCSXr
SBCSWr
SBCSXr
ADDSWrx
ADDSXrx
ADDSXrx64
SUBSWrx
SUBSXrx
SUBSXrx64
https://reviews.llvm.org/D35075
More information about the llvm-commits
mailing list