[PATCH] D35475: [PATCH] [GVN] Ensure replacement instruction dominates its uses

[Daniel Berlin via llvm-commits]

Hey Pedro,
Let's hold off on that. If you want to try to implement the local dominance
approach, i'll see if disabling it works out okay.


On Tue, Jul 18, 2017 at 1:06 AM, Pedro Ferreira via Phabricator <
reviews at reviews.llvm.org> wrote:

> PFerreira added a comment.
>
> A-ha, I see your point. Apologies for the confusion, but as I mentioned
> before, it was my hack on GVN.
>
> I wouldn't be able to say if this improves performance or not; the
> original bug isn't mine. I found it on bugzilla and thought it might be
> something interesting to hack on.
> If you'd prefer to fix the bug by disabling parts of the transformation,
> should I discard this review?
>
>
> https://reviews.llvm.org/D35475
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170718/691952eb/attachment.html>