[PATCH] D35531: [COFF, ARM64] Reserve X18 register by default

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: test/CodeGen/AArch64/arm64-platform-reg.ll:28
+
+; CHECK-RESERVE-X18-COFF-NOT: ldr x18
+; CHECK-RESERVE-X18-COFF-NOT: str x18
----------------
mgrang wrote:
> mstorsjo wrote:
> > Why the custom test prefix for windows/coff? Doesn't the existing CHECK-RESERVE-X18 also work for aarch64-windows?
> I wasn't sure about the "ldr fp" and "Spill". Is fp an alias for x18?
fp is an alias for x29; I think that part of the test just makes sure that nothing tries to use that register for the copying that the test does (especially when x18 isn't available), since that register shouldn't be used for unrelated things.


Repository:
  rL LLVM

https://reviews.llvm.org/D35531