[PATCH] D35294: [CGP] Allow cycles during Phi traversal in OptimizaMemoryInst

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:4281
 
-    // Break use-def graph loops.
-    if (!Visited.insert(V).second) {
-      AddrModeFound = false;
-      break;
-    }
+    // We allow traversing the cyclic Phi nodes.
+    // In case of success after this loop we ensure that traversing through
----------------
"the" is unnecessary.


https://reviews.llvm.org/D35294