[PATCH] D35567: [Sparc] invalid adjustments in TLS_LE/TLS_LDO relocations removed

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 10:12:13 PDT 2017


jyknight added a comment.

Seems probably correct -- Value should always be zero, because ELFObjectWriter.cpp sets Value to 0 and moves the offset into the relocation if hasRelocationAddend() is true, which it is on sparc.

But, yea...it would be really neat if there were tests for the TLS fixups/relocations in llvm/test/MC/Sparc.


https://reviews.llvm.org/D35567





More information about the llvm-commits mailing list