[PATCH] D35517: Add the --chroot option for --reproduce.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 05:45:32 PDT 2017


grimar added a comment.

I uploaded reproduce for which this patch fails currectly here: https://drive.google.com/file/d/0B_OWr6ld9gUmSXhjM0g4Y3I3d3c/view

In short- reproduce contains script that tries to open "/lib/x86_64-linux-gnu/libc.so.6" file. When running under windows,
callstack is

   	lld.exe!lld::elf::error(const llvm::Twine & Msg) Line 100	C++
   	lld.exe!lld::elf::ScriptLexer::setError(const llvm::Twine & Msg) Line 89	C++
  >	lld.exe!`anonymous namespace'::ScriptParser::addFile(llvm::StringRef S) Line 275	C++
   	lld.exe!`anonymous namespace'::ScriptParser::readGroup() Line 310	C++
   	lld.exe!`anonymous namespace'::ScriptParser::readLinkerScript() Line 222	C++

That happens because sys::patch::is_absolute called from addFile uses native style by default and
returns false for /lib/x86_64-linux-gnu/libc.so.6" under windows.

With a little modification for above, patch works for me though. I uploaded changed version:
F3700092: patch.patch <https://reviews.llvm.org/F3700092>

It looks fine for me.


https://reviews.llvm.org/D35517





More information about the llvm-commits mailing list