[PATCH] D34849: [AMDGPU] Add missing hazard for DPP-after-EXEC-write

[Connor Abbott via Phabricator via llvm-commits]

cwabbott added inline comments.


================
Comment at: test/CodeGen/AMDGPU/inserted-wait-states.mir:495
+# VI: S_MOV_B64
+# VI: S_NOP
+# VI: S_NOP
----------------
arsenm wrote:
> Should check the NOP argument is 0. Ideally these would be combined into one nop with the right value later. Also why not use VI-NEXT for all of them?
Sure, I can check that it's 0. Btw, the rest of this file is inconsistent about whether it checks for a 0 argument or not. I didn't use VI-NEXT to be consistent with the rest of the file which doesn't either, but I can change that too.

And yeah, all these NOP's are combined into one by a later pass; I don't remember exactly which one.


https://reviews.llvm.org/D34849