[PATCH] D35518: [COFF, ARM64, CodeView] Add support to emit CodeView debug info for ARM64 COFF

[Grang, Mandeep Singh via llvm-commits]

On 7/17/2017 4:47 PM, Reid Kleckner via Phabricator wrote:
> rnk added inline comments.
>
>
> ================
> Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:307-308
>                                        CodeViewLineTablesGroupDescription));
>       }
> -    if (!EmitCodeView || MMI->getModule()->getDwarfVersion()) {
> +    else if (!EmitCodeView || MMI->getModule()->getDwarfVersion()) {
>         DD = new DwarfDebug(this, &M);
> ----------------
> ruiu wrote:
>> Please fix style.
> The old way of doing this supported emitting both dwarf and CV, which we briefly considered to be interesting. There isn't any real use case for it, but I think I'd prefer it if these things were independent. We shouldn't have a dwarf version flag if the frontend wants us to emit codeview.
@rnk So you mean adding an "else if" here is fine or should I revert 
this to the old way?
>
>
> Repository:
>    rL LLVM
>
> https://reviews.llvm.org/D35518
>
>
>